Fix to deposit liquidity functions#395
Open
jwallbridge wants to merge 1 commit intosolana-developers:mainfrom
Open
Fix to deposit liquidity functions#395jwallbridge wants to merge 1 commit intosolana-developers:mainfrom
jwallbridge wants to merge 1 commit intosolana-developers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the deposit liquidity functions are incorrect in both the anchor and steel folders in token-swap.
To deposit liquidity, we check that the amounts being deposited are in the same proportion as the existing liquidity in the pool. If not, we adjust the amounts accordingly. The resulting amounts are the maximum amounts available of the depositors tokens that satisfy the correct proportion.
Since these program examples are meant to be relatively simple, the fix has been made without introducing auxiliary functions.